GCAFS prep emissions update - fire emissions #3713
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This pull request updates aerosol configuration and emissions handling for the UFS-Aerosols system by consolidating file management and enhancing modularity. Key changes include:
- Removing legacy logic for generating the AERO_ExtData.rc file and consolidating emission configuration files.
- Adding a link to chemical input files in forecast_predet.sh and updating configuration templates in both aerosol and chemical configuration files.
- Refactoring configuration files to improve clarity and maintainability.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ush/parsing_namelists_GOCART.sh | Removed legacy dynamic generation of AERO_ExtData.rc. |
| ush/forecast_predet.sh | Added linking for CHEM_INPUT to ensure chemical input file availability. |
| parm/ufs/gocart/ExtData.* | Removed obsolete emission configuration files, consolidating them into AERO_ExtData.rc. |
| parm/ufs/gocart/AERO_ExtData.rc | Updated emission entries to use chemical input paths and adjusted emission factors. |
| parm/chem/chem_emission.yaml.j2 | Updated templating loops for QFED variables and file copying operations. |
| dev/parm/config/gfs/config.com | Added new chemical template paths. |
| dev/parm/config/gcafs/config.aero.j2 | Reorganized aerosol sections and introduced new aerosol emission settings. |
bbakernoaa
force-pushed
the
feature/prep_emis_rework
branch
from
2e06fb3 to
b534a8b
Compare
|
@aerorahul @DavidHuber-NOAA can we please get this reviewed. It's important for the GCAFS implementation |
Co-authored-by: David Huber <[email protected]>
Co-authored-by: David Huber <[email protected]>
| ${NLN} "${COMIN_CHEM_INPUT}" "${DATA}/ChemInput" | ||
| # Create the ChemInput directory in the local run directory | ||
|
|
||
| # if [[ ! -d "${DATA}/ChemInput" ]]; then mkdir -p "${DATA}/ChemInput"; fi |
There was a problem hiding this comment.
@bbakernoaa we should use cpreq here. Linking from COMIN is not allowed (at least not yet) by EE2 standards and we shouldn't be linking whole directories. I'm OK with adding a TODO here if you will create a follow-up issue to tackle this.
Co-authored-by: David Huber <[email protected]>
Co-authored-by: David Huber <[email protected]>
Co-authored-by: David Huber <[email protected]>
Co-authored-by: David Huber <[email protected]>
|
@DavidHuber-NOAA I think I took care of all your suggestions and requests |
| dep_dict = {'type': 'task', 'name': f'{self.run}_stage_ic'} | ||
| dependencies.append(rocoto.add_dependency(dep_dict)) | ||
| dependencies = rocoto.create_dependency(dep_condition='or', dep=dependencies) | ||
|
|
There was a problem hiding this comment.
@bbakernoaa double check these changes, I think it's leading to some issues in dependencies
There was a problem hiding this comment.
<dependency>
<and>
<or>
<taskdep task="gcdas_sfcanl"/>
<taskdep task="gcdas_aeroanlfinal"/>
<taskdep task="gcdas_stage_ic"/>
</or>
<taskdep task="gcdas_prep_emissions"/>
</and>
</dependency>
I don't think this is correct, we need sfcanl and aeroanlfinal or we need stage_ic
There was a problem hiding this comment.
can you explain a little more. It's been running for over a month long simulation at this point
There was a problem hiding this comment.
I think we need it to be
<dependency>
<and>
<or>
<and>
<taskdep task="gcdas_sfcanl"/>
<taskdep task="gcdas_aeroanlfinal"/>
</and>
<taskdep task="gcdas_stage_ic"/>
</or>
<taskdep task="gcdas_prep_emissions"/>
</and>
</dependency>
There was a problem hiding this comment.
doesn't this mean that its (gcafs_prep_emissions) & ( gcdas_sfc_anl | gcdas_aeroanlfinal | gcdas_stage_ic)
There was a problem hiding this comment.
so what you are saying is that we need
(gcafs_prep_emissions) & ( (gcdas_sfc_anl & gcdas_aeroanlfinal) | gcdas_stage_ic)
There was a problem hiding this comment.
ok i can make that change
There was a problem hiding this comment.
@bbakernoaa yes, so we need both sfcanl and aeroanlfinal, not one of them, to be done before the forecast can start
5 participants
Description
This pull request introduces significant updates to the aerosol configuration and emission handling in the UFS-Aerosols system, streamlining file management, improving modularity, and consolidating configuration files. Key changes include restructuring aerosol configuration files, enhancing biomass burning emissions handling, and updating the chemical input file linking process.
Aerosol Configuration Updates:
config.aero.j2to organize settings into distinct sections for aerosol and emission configurations, including the addition of new variables likeAERO_EMIS_FIRE_VERSIONandAERO_EMIS_FIRE_HIST. [1] [2]Emission Data Management:
ExtData.gbbepx,ExtData.qfed, andExtData.none) into a single file,AERO_ExtData.rc, for better modularity and maintainability. Removed redundant and unused emission entries. [1] [2] [3] [4]Chemical Input File Handling:
CHEM_INPUT) inforecast_predet.shto ensure proper file availability during runtime.Removal of Legacy Code:
AERO_ExtData.rcinparsing_namelists_GOCART.sh, as the new consolidated configuration file eliminates the need for dynamic generation.Additional Updates:
config.comto include new template paths for chemical restart and input files, improving file organization.Type of change
Change characteristics
How has this been tested?
Checklist